Added caveats section to TN0012 #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-monodocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
smyrick
reviewed
Feb 9, 2024
src/content/technotes/TN0012-namespacing-by-separation-of-concern.mdx
Outdated
Show resolved
Hide resolved
smyrick
reviewed
Feb 9, 2024
src/content/technotes/TN0012-namespacing-by-separation-of-concern.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Shane Myrick <shane@apollographql.com>
benjie
reviewed
Feb 15, 2024
There was a problem hiding this comment.
Thank you for addressing this, I think a caveats section is a wise and straightforward solution. I'd also like to suggest that you comment near the top that this caveat exists, e.g. "Please note: this technote isn't fully in compliance with the GraphQL specification as it currently stands, please review the Caveats section for more information."
I've left some further suggestions below.
Thanks again!
src/content/technotes/TN0012-namespacing-by-separation-of-concern.mdx
Outdated
Show resolved
Hide resolved
src/content/technotes/TN0012-namespacing-by-separation-of-concern.mdx
Outdated
Show resolved
Hide resolved
benjie
reviewed
Feb 15, 2024
src/content/technotes/TN0012-namespacing-by-separation-of-concern.mdx
Outdated
Show resolved
Hide resolved
…ern.mdx Co-authored-by: Benjie <benjie@jemjie.com>
…ern.mdx Co-authored-by: Benjie <benjie@jemjie.com>
…ern.mdx Co-authored-by: Benjie <benjie@jemjie.com>
smyrick
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.